Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Call OpenFile instead of Open in CacheOnReadFs (fixes #193) #332

Merged
merged 1 commit into from
Jan 5, 2022
Merged

Call OpenFile instead of Open in CacheOnReadFs (fixes #193) #332

merged 1 commit into from
Jan 5, 2022

Conversation

pojntfx
Copy link
Contributor

@pojntfx pojntfx commented Dec 25, 2021

This closes #193 by calling OpenFile instead of Open when appropiate, thus passing i.e. O_CREATE to the layer. Already tested in https://github.com/pojntfx/stfs.

@CLAassistant
Copy link

CLAassistant commented Dec 25, 2021 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@pojntfx pojntfx mentioned this pull request Dec 25, 2021
Closed
@0xmichalis 0xmichalis merged commit cd35605 into spf13:master Jan 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@0xmichalis 0xmichalis 0xmichalis approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

CacheOnReadFs.OpenFile fails to create file with O_CREATE flag
3 participants
@pojntfx @CLAassistant @0xmichalis