Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CacheOnReadFs.OpenFile fails to create file with O_CREATE flag #193

Closed
cheesedosa opened this issue Jan 11, 2019 · 2 comments · Fixed by #332
Closed

CacheOnReadFs.OpenFile fails to create file with O_CREATE flag #193

cheesedosa opened this issue Jan 11, 2019 · 2 comments · Fixed by #332
Labels
bug

Comments

@cheesedosa
Copy link

This fails at copyToLayer() (link) which calls os.Open() (link) which fails with no such file or directory as the file doesn't exist and needs to be created.
@cheesedosa cheesedosa mentioned this issue Jan 11, 2019
Merged
@0xmichalis 0xmichalis added the bug label Mar 27, 2020
@pojntfx
Copy link
Contributor

pojntfx commented Dec 25, 2021

Ran into this today as well while trying to use afero for https://github.com/pojntfx/stfs - am I correct to assume that fixing this would basically require switching to calling the OpenFile instead of the Open method on the layer so that the perm flags etc. would be transferred as well?

pojntfx added a commit to pojntfx/stfs that referenced this issue Dec 25, 2021
@pojntfx
fix: Add workaround for broken Open implementation in `CacheOnReadF…
f793dca 
…s` (spf13/afero#193)
pojntfx added a commit to pojntfx/stfs that referenced this issue Dec 25, 2021
@pojntfx
fix: Use fork of Afero until merge of PR which fixes OpenFile (spf1…
4ad379b 
…3/afero#193)
@pojntfx pojntfx mentioned this issue Dec 25, 2021
Merged
@pojntfx
Copy link
Contributor

pojntfx commented Dec 25, 2021

I've opened #332 which will close this issue.

0xmichalis added a commit that referenced this issue Jan 5, 2022
@0xmichalis
Merge pull request #332 from pojntfx/master
cd35605 
Call `OpenFile` instead of `Open` in `CacheOnReadFs` (fixes #193)
pojntfx added a commit to pojntfx/stfs that referenced this issue Feb 26, 2023
@pojntfx
fix: Add workaround for broken Open implementation in `CacheOnReadF…
9f5c1b9 
…s` (spf13/afero#193)
pojntfx added a commit to pojntfx/stfs that referenced this issue Feb 26, 2023
@pojntfx
fix: Use fork of Afero until merge of PR which fixes OpenFile (spf1…
a139666 
…3/afero#193)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Call OpenFile instead of Open in CacheOnReadFs (fixes #193)
3 participants
@0xmichalis @cheesedosa @pojntfx