Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add CI job names #199

Merged
merged 1 commit into from
Nov 30, 2023
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
28 changes: 13 additions & 15 deletions .github/workflows/test.yaml
Original file line number Diff line number Diff line change
@@ -1,26 +1,24 @@
on: [pull_request]

jobs:
## PHPUNIT
phpunit:
name: PHPUnit
runs-on: ubuntu-latest
strategy:
matrix:
php-version: [8.1, 8.2, 8.3]
composer-flags: [null]
php-version: ['8.1', '8.2', '8.3']
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

flags was unused
quote YAML floats

steps:
- uses: actions/checkout@v4
- uses: shivammathur/setup-php@v2
with:
php-version: ${{ matrix.php-version }}
coverage: none
extensions: intl curl
- run: php -v
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PHP version is included in the output of shivammathur/setup-php

- run: composer update ${{ matrix.composer-flags }} --no-interaction --no-progress --prefer-dist --ansi
- run: composer update --no-interaction --no-progress --prefer-dist --ansi
- run: composer test:unit

## PHPSTAN
phpstan:
name: PHPStan
runs-on: ubuntu-latest
steps:
- name: Checkout
Expand All @@ -32,17 +30,17 @@ jobs:
php-version: '8.1'
coverage: none
env:
COMPOSER_TOKEN: ${{ secrets.GITHUB_TOKEN }}
COMPOSER_TOKEN: ${{ github.token }}
Comment on lines -35 to +33
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

New name!

update: true

- name: Install dependencies
run: composer install --prefer-dist --no-interaction --no-progress --optimize-autoloader
run: composer update --prefer-dist --no-interaction --no-progress --optimize-autoloader
Comment on lines -39 to +37
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We do not have a lock file in the repo.


- name: PHPStan tests
run: composer test:types

## RECTOR
rector:
name: Rector
runs-on: ubuntu-latest
steps:
- name: Checkout
Expand All @@ -54,17 +52,17 @@ jobs:
php-version: '8.1'
coverage: none
env:
COMPOSER_TOKEN: ${{ secrets.GITHUB_TOKEN }}
COMPOSER_TOKEN: ${{ github.token }}
update: true

- name: Install dependencies
run: composer install --prefer-dist --no-interaction --no-progress --optimize-autoloader
run: composer update --prefer-dist --no-interaction --no-progress --optimize-autoloader

- name: PHPStan tests
run: composer test:refactor

## PINT
pint:
name: Pint
runs-on: ubuntu-latest
steps:
- name: Checkout
Expand All @@ -77,11 +75,11 @@ jobs:
coverage: none
tools: cs2pr
env:
COMPOSER_TOKEN: ${{ secrets.GITHUB_TOKEN }}
COMPOSER_TOKEN: ${{ github.token }}
update: true

- name: Install dependencies
run: composer install --prefer-dist --no-interaction --no-progress --optimize-autoloader
run: composer update --prefer-dist --no-interaction --no-progress --optimize-autoloader

- name: Run Pint
run: ./vendor/bin/pint --test --format=checkstyle | cs2pr
run: composer exec -- pint --test --format=checkstyle | cs2pr
Comment on lines -87 to +85
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is a Composer command to start binaries.

Loading