Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add CI job names #199

Merged
merged 1 commit into from
Nov 30, 2023
Merged

Add CI job names #199

merged 1 commit into from
Nov 30, 2023

Conversation

szepeviktor
Copy link
Contributor

Move comments to name:

php-version: [8.1, 8.2, 8.3]
composer-flags: [null]
php-version: ['8.1', '8.2', '8.3']
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

flags was unused
quote YAML floats

steps:
- uses: actions/checkout@v4
- uses: shivammathur/setup-php@v2
with:
php-version: ${{ matrix.php-version }}
coverage: none
extensions: intl curl
- run: php -v
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PHP version is included in the output of shivammathur/setup-php

Comment on lines -35 to +33
COMPOSER_TOKEN: ${{ secrets.GITHUB_TOKEN }}
COMPOSER_TOKEN: ${{ github.token }}
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

New name!

Comment on lines -39 to +37
run: composer install --prefer-dist --no-interaction --no-progress --optimize-autoloader
run: composer update --prefer-dist --no-interaction --no-progress --optimize-autoloader
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We do not have a lock file in the repo.

Comment on lines -87 to +85
run: ./vendor/bin/pint --test --format=checkstyle | cs2pr
run: composer exec -- pint --test --format=checkstyle | cs2pr
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is a Composer command to start binaries.

@spekulatius
Copy link
Owner

Thank you @szepeviktor !

@spekulatius spekulatius merged commit 696109a into spekulatius:master Nov 30, 2023
5 of 6 checks passed
@szepeviktor szepeviktor deleted the patch-1 branch November 30, 2023 18:23
@szepeviktor
Copy link
Contributor Author

Glad to contribute.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants