Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gergo/forward ref type #260

Merged
merged 2 commits into from
Feb 15, 2023
Merged

gergo/forward ref type #260

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
ea7baf8
fix(type_checking): make sure forwardrefs blank pass type checking
gjedlicska Feb 15, 2023
ae42bec
style(formatting): rerun formatting
gjedlicska Feb 15, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions src/specklepy/objects/base.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,7 @@
Any,
ClassVar,
Dict,
ForwardRef,
List,
Optional,
Set,
Expand Down Expand Up @@ -217,6 +218,9 @@ def _validate_type(t: Optional[type], value: Any) -> Tuple[bool, Any]:
return True, t(value)

if getattr(t, "__module__", None) == "typing":
if isinstance(t, ForwardRef):
return True, value

origin = getattr(t, "__origin__")
# below is what in nicer for >= py38
# origin = get_origin(t)
Expand Down
1 change: 1 addition & 0 deletions tests/unit/test_type_validation.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -106,6 +106,7 @@ def __init__(self, foo: str) -> None:
True,
fake_bases,
),
(List["int"], [2, 3, 4], True, [2, 3, 4]),
],
)
def test_validate_type(
Expand Down