Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gergo/forward ref type #260

Merged
merged 2 commits into from
Feb 15, 2023
Merged

gergo/forward ref type #260

merged 2 commits into from
Feb 15, 2023

Conversation

gjedlicska
Copy link
Collaborator

  • fix(type_checking): make sure forwardrefs blank pass type checking
  • style(formatting): rerun formatting

Description & motivation

Changes:

To-do before merge:

Screenshots:

Validation of changes:

Checklist:

  • My pull request follows the guidelines in the Contributing guide?
  • My pull request does not duplicate any other open Pull Requests for the same update/change?
  • My commits are related to the pull request and do not amend unrelated code or documentation.
  • My code follows a similar style to existing code.
  • I have added appropriate tests.
  • I have updated or added relevant documentation.

References

@gjedlicska gjedlicska requested a review from JR-Morgan February 15, 2023 18:22
@codecov
Copy link

codecov bot commented Feb 15, 2023

Codecov Report

Base: 91.20% // Head: 91.20% // Increases project coverage by +0.00% 🎉

Coverage data is based on head (ae42bec) compared to base (8352bb5).
Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #260   +/-   ##
=======================================
  Coverage   91.20%   91.20%           
=======================================
  Files          65       65           
  Lines        4444     4446    +2     
=======================================
+ Hits         4053     4055    +2     
  Misses        391      391           
Impacted Files Coverage Δ
tests/unit/test_type_validation.py 100.00% <ø> (ø)
src/specklepy/objects/base.py 84.13% <100.00%> (+0.11%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

Copy link
Member

@JR-Morgan JR-Morgan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested in Blender with a few problematic pointcloud objects.
Works great!

@gjedlicska gjedlicska merged commit 3dd56dc into main Feb 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants