Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

speckle type sync with core #241

Merged
merged 13 commits into from
Dec 21, 2022
Merged

speckle type sync with core #241

merged 13 commits into from
Dec 21, 2022

Conversation

gjedlicska
Copy link
Collaborator

  • fix(base): update speckle_type creation to better match Core
  • test(base): update base tests to properly test the speckle_type generation
  • fix(objects): update structural objects to better match core
  • refactor(objects): fix import structure and typing errors for objects
  • style(all): sort imports with isort
  • add missing object definitions from core
  • rework type checking in base
  • additional test cases for type validation

Description & motivation

Changes:

To-do before merge:

Screenshots:

Validation of changes:

Checklist:

  • My pull request follows the guidelines in the Contributing guide?
  • My pull request does not duplicate any other open Pull Requests for the same update/change?
  • My commits are related to the pull request and do not amend unrelated code or documentation.
  • My code follows a similar style to existing code.
  • I have added appropriate tests.
  • I have updated or added relevant documentation.

References

@gjedlicska gjedlicska requested a review from JR-Morgan December 16, 2022 20:18
@codecov
Copy link

codecov bot commented Dec 16, 2022

Codecov Report

Base: 90.71% // Head: 91.18% // Increases project coverage by +0.47% 🎉

Coverage data is based on head (59a6950) compared to base (ebb703e).
Patch coverage: 98.24% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #241      +/-   ##
==========================================
+ Coverage   90.71%   91.18%   +0.47%     
==========================================
  Files          58       62       +4     
  Lines        4016     4301     +285     
==========================================
+ Hits         3643     3922     +279     
- Misses        373      379       +6     
Impacted Files Coverage Δ
src/specklepy/api/resources/object.py 100.00% <ø> (ø)
src/specklepy/api/resources/server.py 97.14% <ø> (ø)
src/specklepy/paths.py 66.66% <ø> (ø)
tests/test_active_user.py 100.00% <ø> (ø)
tests/test_commit.py 100.00% <ø> (ø)
tests/test_host_applications.py 100.00% <ø> (ø)
tests/test_objects.py 100.00% <ø> (ø)
tests/test_other_user.py 100.00% <ø> (ø)
tests/test_transforms.py 100.00% <ø> (ø)
tests/test_structural.py 70.49% <80.00%> (-3.04%) ⬇️
... and 51 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@AlanRynne AlanRynne self-requested a review December 20, 2022 11:01
Copy link
Member

@AlanRynne AlanRynne left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed IRL with Gergo 🚀 Good to go

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants