Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update default value of results from 0.0 to None to align with the default value in speckle-sharp #240

Merged

Conversation

ItsPatrickHe
Copy link

@ItsPatrickHe ItsPatrickHe commented Dec 16, 2022

Description & motivation

I made this PR because in the speckle sharp repository, for example, as you can see for the Result1D class, the initial default value for all the attributes will be null when not set. These are indicated in the type as well. Could you check this PR to see if this change is correct?
image

Changes:

To-do before merge:

Screenshots:

Validation of changes:

Checklist:

  • My pull request follows the guidelines in the Contributing guide?
  • My pull request does not duplicate any other open Pull Requests for the same update/change?
  • My commits are related to the pull request and do not amend unrelated code or documentation.
  • My code follows a similar style to existing code.
  • I have added appropriate tests.
  • I have updated or added relevant documentation.

References

@codecov
Copy link

codecov bot commented Dec 16, 2022

Codecov Report

Base: 91.21% // Head: 90.71% // Decreases project coverage by -0.49% ⚠️

Coverage data is based on head (c91f673) compared to base (5ae022d).
Patch has no changes to coverable lines.

❗ Current head c91f673 differs from pull request most recent head 659c57e. Consider uploading reports for the commit 659c57e to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #240      +/-   ##
==========================================
- Coverage   91.21%   90.71%   -0.50%     
==========================================
  Files          63       58       -5     
  Lines        4312     4016     -296     
==========================================
- Hits         3933     3643     -290     
+ Misses        379      373       -6     
Impacted Files Coverage Δ
src/specklepy/objects/base.py 78.33% <0.00%> (-3.92%) ⬇️
src/specklepy/objects/other.py 97.36% <0.00%> (-0.51%) ⬇️
src/specklepy/objects/units.py 90.90% <0.00%> (-0.27%) ⬇️
src/specklepy/objects/geometry.py 87.63% <0.00%> (-0.25%) ⬇️
tests/conftest.py 98.64% <0.00%> (ø)
tests/test_base.py 100.00% <0.00%> (ø)
tests/test_user.py 100.00% <0.00%> (ø)
tests/test_branch.py 100.00% <0.00%> (ø)
tests/test_commit.py 100.00% <0.00%> (ø)
tests/test_server.py 96.42% <0.00%> (ø)
... and 51 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@gjedlicska gjedlicska self-requested a review December 21, 2022 11:00
@gjedlicska gjedlicska self-requested a review January 4, 2023 09:30
@gjedlicska gjedlicska merged commit 93c1ec9 into specklesystems:main Jan 4, 2023
@RobClaessensRHDHV
Copy link
Contributor

Hi @gjedlicska,
Great that his has been merged, together with your other updates of the specklepy structural objects (#241). We are depending on these updates for our own repo.
Do you know when these updates will be released as pip installable?

@gjedlicska
Copy link
Collaborator

Hey @RobClaessensRHDHV

We've just published a new release of specklepy -> 2.11.0
There are a few bigger changes in this one, so please let me know if you run into anything unexpected.

@RobClaessensRHDHV
Copy link
Contributor

@gjedlicska

Nice! We will check it out next week :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants