Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(validation): also allow URLs in download locations #763

Merged
merged 1 commit into from
Sep 19, 2023
Merged

fix(validation): also allow URLs in download locations #763

merged 1 commit into from
Sep 19, 2023

Conversation

maxhbr
Copy link
Member

@maxhbr maxhbr commented Sep 18, 2023

All URLs are valid download locations.

This closes #761 and #762.

@maxhbr maxhbr linked an issue Sep 18, 2023 that may be closed by this pull request
Tool is failing to parse URL like git@github.com:siimon/prom-client.git in downloadLocation #762
Closed
@maxhbr
fix(validation): also allow URLs in download locations
0b8f6dc 
fix spdx#761
fix spdx#762

Signed-off-by: Maximilian Huber <maximilian.huber@tngtech.com>
@maxhbr maxhbr force-pushed the maxhbr/fix761and762 branch from 275d245 to 0b8f6dc Compare September 18, 2023 09:38
armintaenzertng
armintaenzertng requested changes Sep 18, 2023
View reviewed changes
Copy link
Collaborator

@armintaenzertng armintaenzertng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add the test cases from the issues

@maxhbr
Copy link
Member Author

maxhbr commented Sep 19, 2023

I would prefer to not extend the current URL testcases, to avoid confusing URL semantics with recommendations on which URLs to use.

armintaenzertng
armintaenzertng approved these changes Sep 19, 2023
View reviewed changes
Copy link
Collaborator

@armintaenzertng armintaenzertng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK, then it looks good to me :)

@armintaenzertng armintaenzertng merged commit ed9a135 into spdx:main Sep 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@armintaenzertng armintaenzertng armintaenzertng approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@maxhbr @armintaenzertng