Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tool is failing to parse URL like git@github.com:siimon/prom-client.git in downloadLocation #762

Closed
pushkargr opened this issue Sep 14, 2023 · 1 comment · Fixed by #763
Labels

Comments

@pushkargr
Copy link

pushkargr commented Sep 14, 2023

URL like git@github.com:siimon/prom-client.git are valid download locations. Github provides the link this way. But the tool is marking this as invalid.

package download_location must be a valid download location according to the specification, but is: git@github.com:siimon/prom-client.git

image

Could the specification be incorrect in this case and the tool should be able to adjust it?

@maxhbr maxhbr added the bug label Sep 16, 2023
@maxhbr
Copy link
Member

maxhbr commented Sep 16, 2023

Not sure what the specification says about that. Download Location is either a URL or a "VCS location", where the "VCS location" is of the following form:

<vcs_tool>+<transport>://<host_name>[/<path_to_repository>][@<revision_tag_or_branch>][#<sub_path>]

Not sure if that example falls under URL or "VCS location", but the VCS Location seems to always contain ://.

On the other hand, the specification has the example git+git@git.myproject.org:MyProject which is close to your form.

maxhbr added a commit to maxhbr/tools-python that referenced this issue Sep 18, 2023
fix spdx#761
fix spdx#762

Signed-off-by: Maximilian Huber <maximilian.huber@tngtech.com>
@maxhbr maxhbr linked a pull request Sep 18, 2023 that will close this issue
maxhbr added a commit to maxhbr/tools-python that referenced this issue Sep 18, 2023
fix spdx#761
fix spdx#762

Signed-off-by: Maximilian Huber <maximilian.huber@tngtech.com>
armintaenzertng pushed a commit that referenced this issue Sep 19, 2023
fix #761
fix #762

Signed-off-by: Maximilian Huber <maximilian.huber@tngtech.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants