Make DB connection optional #290
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Until now Ray did not work when the Laravel project did not use a DB connection (by disabling the DatabaseServiceProvider). That case resulted in a `Target class [db] does not exist.` exception. To solve this, checks are introduced to just ignore the DB watchers. See: spatie/ray#771
|
Great PR, thanks! |
crynobone
added a commit
to crynobone/laravel-ray
that referenced
this pull request
Mar 23, 2023
- additional improvements to spatie#290 Internally, `DB::listen()` is equivalent to calling `app('db')->connection()->listen()` which initiate a database connection and cause issue such as larastan/larastan#1588 Signed-off-by: Mior Muhammad Zaki <crynobone@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Until now Ray did not work when the Laravel project did not use a DB connection (by disabling the DatabaseServiceProvider). That case resulted in a
Target class [db] does not exist.exception. To solve this, checks are introduced to just ignore the DB watchers.See: spatie/ray#771