Merge pull request #290 from lentex/feature/no-db-required

Make DB connection optional
spatie · Jan 26, 2023 · b1dfa5b · b1dfa5b
2 parents c61b10a + ffaa562
commit b1dfa5b
Show file tree

Hide file tree

Showing 4 changed files with 24 additions and 0 deletions.
diff --git a/src/Watchers/DuplicateQueryWatcher.php b/src/Watchers/DuplicateQueryWatcher.php
@@ -20,6 +20,10 @@ public function register(): void
 
         $this->enabled = $settings->send_duplicate_queries_to_ray;
 
+        if (! app()->bound('db')) {
+           return;
+        }
+
         DB::listen(function (QueryExecuted $query) {
             if (! $this->enabled()) {
                 return;

diff --git a/src/Watchers/QueryWatcher.php b/src/Watchers/QueryWatcher.php
@@ -25,6 +25,10 @@ public function register(): void
 
         $this->enabled = $settings->send_queries_to_ray;
 
+        if (! app()->bound('db')) {
+            return;
+        }
+
         DB::listen(function (QueryExecuted $query) {
             if (! $this->enabled()) {
                 return;

diff --git a/src/Watchers/SlowQueryWatcher.php b/src/Watchers/SlowQueryWatcher.php
@@ -19,6 +19,10 @@ public function register(): void
         $this->enabled = $settings->send_slow_queries_to_ray ?? false;
         $this->minimumTimeInMs = $settings->slow_query_threshold_in_ms ?? $this->minimumTimeInMs;
 
+        if (! app()->bound('db')) {
+            return;
+        }
+
         DB::listen(function (QueryExecuted $query) {
             if (! $this->enabled()) {
                 return;

diff --git a/tests/RayTest.php b/tests/RayTest.php
@@ -1,6 +1,7 @@
 <?php
 
 use Illuminate\Support\Arr;
+use Illuminate\Support\Facades\Facade;
 use Illuminate\Support\Facades\Log;
 use Spatie\LaravelRay\Ray;
 use Spatie\LaravelRay\RayServiceProvider;
@@ -151,3 +152,14 @@
 
     expect(Ray::$projectName)->toEqual('my-project');
 });
+
+it('still boots and works although the DB facade has not been bound', function () {
+    unset($this->app['db']);
+    Facade::clearResolvedInstance('db');
+
+    (new RayServiceProvider($this->app))->boot();
+
+    ray('foo');
+
+    expect($this->client->sentRequests())->toHaveCount(1);
+});