-
Notifications
You must be signed in to change notification settings - Fork 32
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
JP-2581: fix to allow multiprocessing for jump #87
Conversation
3fe5718
to
bbfa13d
Compare
bbfa13d
to
3722d2a
Compare
Codecov Report
@@ Coverage Diff @@
## main #87 +/- ##
===========================================
- Coverage 89.29% 71.66% -17.63%
===========================================
Files 16 16
Lines 2419 2432 +13
===========================================
- Hits 2160 1743 -417
- Misses 259 689 +430
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good now.
Needs a change log entry and should we worry about the failing romancal CI test? Or is that due to unrelated changes in the function signatures from saturation step updates?
@hbushouse I just opened a PR in jwst to fix some of the tests there and point to this branch. once that's approved i'll change the stcal version back so it can be merged |
@cshanahan1 Do we need to add the same parameter to romancal? If so please submit a PR. |
Are we OK to merge this now on the stcal side, so that we can get a new release out, before we merge things on the jwst side? |
@hbushouse i think so. im working on getting the roman tests to pass now but im fairly certain it's just a matter of adding the new parameter there and wont require any more changes here |
Fixes an issue in jump where the input gdq arrays were being modified which was causing tests to fail in JWST when the step was being run in multiprocessing mode. If multiple processes are run, the gdq/data arrays are copied before
find_crs
and not again within the function (which in this mode is running on slices).