-
Notifications
You must be signed in to change notification settings - Fork 169
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
JP-2581: allow multiprocessing for jump detection #6845
Conversation
c98e050
to
d46bf2e
Compare
Codecov Report
@@ Coverage Diff @@
## master #6845 +/- ##
=======================================
Coverage 79.59% 79.59%
=======================================
Files 418 418
Lines 37064 37067 +3
=======================================
+ Hits 29500 29503 +3
Misses 7564 7564
*This pull request uses carry forward flags. Click here to find out more.
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good.
I seem to recall, however, that the code over in stcal allows for integer values of max_cores
, so I'm just curious why all of these tests needed to have the value changed from 1 to none
?
I changed it from allowing integer values to just allowing strings. JumpStep spec only allows this to be strings so I just kept that there to avoid confusion. |
The CI tests all passed, when using your stcal branch. So that can be changed back now and we'll go ahead and merge. By the way, how does this relate to PR #6815 ? Looks like it duplicates the code updates, but diverges in terms of unit tests. |
I just updated the existing unit tests here, it looks like that PR adds a new one. |
OK, sounds good. |
d46bf2e
to
8b38114
Compare
8b38114
to
8efb91e
Compare
re-enable multiprocessing for jump, fix tests
d0af6d2
to
bcfe929
Compare
re-enable multiprocessing for jump, fix tests
Re-enable multiprocessing for jump detection.
required for spacetelescope/stcal#87