Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

JP-2581: allow multiprocessing for jump detection #6845

Merged
merged 1 commit into from
May 16, 2022

Conversation

cshanahan1
Copy link
Collaborator

Re-enable multiprocessing for jump detection.

required for spacetelescope/stcal#87

@cshanahan1 cshanahan1 force-pushed the jump_multiprocess branch from c98e050 to d46bf2e Compare May 16, 2022 17:20
@cshanahan1 cshanahan1 requested a review from hbushouse May 16, 2022 17:24
@codecov
Copy link

codecov bot commented May 16, 2022

Codecov Report

Merging #6845 (d46bf2e) into master (80b0aaf) will increase coverage by 0.00%.
The diff coverage is 100.00%.

❗ Current head d46bf2e differs from pull request most recent head bcfe929. Consider uploading reports for the commit bcfe929 to get more accurate results

@@           Coverage Diff           @@
##           master    #6845   +/-   ##
=======================================
  Coverage   79.59%   79.59%           
=======================================
  Files         418      418           
  Lines       37064    37067    +3     
=======================================
+ Hits        29500    29503    +3     
  Misses       7564     7564           
Flag Coverage Δ *Carryforward flag
nightly 79.57% <100.00%> (ø) Carriedforward from 80b0aaf
unit 53.65% <ø> (ø)

*This pull request uses carry forward flags. Click here to find out more.

Impacted Files Coverage Δ
jwst/jump/jump.py 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 80b0aaf...bcfe929. Read the comment docs.

Copy link
Collaborator

@hbushouse hbushouse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

I seem to recall, however, that the code over in stcal allows for integer values of max_cores, so I'm just curious why all of these tests needed to have the value changed from 1 to none?

@cshanahan1
Copy link
Collaborator Author

Looks good.

I seem to recall, however, that the code over in stcal allows for integer values of max_cores, so I'm just curious why all of these tests needed to have the value changed from 1 to none?

I changed it from allowing integer values to just allowing strings. JumpStep spec only allows this to be strings so I just kept that there to avoid confusion.

@hbushouse
Copy link
Collaborator

The CI tests all passed, when using your stcal branch. So that can be changed back now and we'll go ahead and merge.

By the way, how does this relate to PR #6815 ? Looks like it duplicates the code updates, but diverges in terms of unit tests.

@cshanahan1
Copy link
Collaborator Author

I just updated the existing unit tests here, it looks like that PR adds a new one.

@hbushouse
Copy link
Collaborator

Looks good.
I seem to recall, however, that the code over in stcal allows for integer values of max_cores, so I'm just curious why all of these tests needed to have the value changed from 1 to none?

I changed it from allowing integer values to just allowing strings. JumpStep spec only allows this to be strings so I just kept that there to avoid confusion.

OK, sounds good.

re-enable multiprocessing for jump, fix tests
@cshanahan1 cshanahan1 force-pushed the jump_multiprocess branch from d0af6d2 to bcfe929 Compare May 16, 2022 20:41
@hbushouse hbushouse merged commit 85c7baa into spacetelescope:master May 16, 2022
stscieisenhamer pushed a commit to stscieisenhamer/jwst that referenced this pull request Nov 21, 2022
re-enable multiprocessing for jump, fix tests
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants