-
Notifications
You must be signed in to change notification settings - Fork 22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
RAD-172 Sky Background #432
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #432 +/- ##
==========================================
+ Coverage 95.38% 95.45% +0.06%
==========================================
Files 4 4
Lines 195 198 +3
==========================================
+ Hits 186 189 +3
Misses 9 9 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me! Thanks, @PaulHuwe! I only have one question about the units for the background level.
Regression tests have completely passed. |
Thanks. @mairanteodoro , I do want to understand if the DN / s is needed for now or not; it's conceptually wrong but we can defer correction until later if needed. |
The The example that I gave to @PaulHuwe was from a regression test that checks for the results from the However, the mosaic pipeline runs |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, @PaulHuwe!
Resolves RAD-172
Closes #247
This PR adds a sky background schema.
Checklist
CHANGES.rst
under the corresponding subsection