Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RAD-172 Sky Background #432

Merged
merged 8 commits into from
Aug 6, 2024
Merged

Conversation

PaulHuwe
Copy link
Collaborator

@PaulHuwe PaulHuwe commented Aug 5, 2024

Resolves RAD-172

Closes #247

This PR adds a sky background schema.

Checklist

Copy link

codecov bot commented Aug 5, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 95.45%. Comparing base (c1811ab) to head (5590671).
Report is 147 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #432      +/-   ##
==========================================
+ Coverage   95.38%   95.45%   +0.06%     
==========================================
  Files           4        4              
  Lines         195      198       +3     
==========================================
+ Hits          186      189       +3     
  Misses          9        9              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@PaulHuwe PaulHuwe marked this pull request as ready for review August 5, 2024 02:43
@PaulHuwe PaulHuwe requested review from kdupriestsci, jbrookens and a team as code owners August 5, 2024 02:43
Copy link
Collaborator

@ddavis-stsci ddavis-stsci left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@mairanteodoro mairanteodoro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me! Thanks, @PaulHuwe! I only have one question about the units for the background level.

src/rad/resources/schemas/sky_background-1.0.0.yaml Outdated Show resolved Hide resolved
@PaulHuwe
Copy link
Collaborator Author

PaulHuwe commented Aug 5, 2024

Regression tests have completely passed.

@schlafly
Copy link
Collaborator

schlafly commented Aug 5, 2024

Thanks. @mairanteodoro , I do want to understand if the DN / s is needed for now or not; it's conceptually wrong but we can defer correction until later if needed.

@mairanteodoro
Copy link
Contributor

mairanteodoro commented Aug 5, 2024

@mairanteodoro , I do want to understand if the DN / s is needed for now or not; it's conceptually wrong but we can defer correction until later if needed.

The DN / s unit was just an example (not a requirement) that I provided to @PaulHuwe so that he could start his work; it is absolutely not necessary, since the sky match step will work fine with either unit.

The example that I gave to @PaulHuwe was from a regression test that checks for the results from the SkyMatchStep only. It uses the _cal files from this association file from Artifactory. The data array in those _cal files have all DN / s units and that's what's passed on to SkyMatchStep.

However, the mosaic pipeline runs FluxStep before SkyMatchStep, which fixes the unit issue (everything after FluxStep is in MJy/sr).

Copy link
Contributor

@mairanteodoro mairanteodoro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @PaulHuwe!

@PaulHuwe PaulHuwe merged commit f9822f7 into spacetelescope:main Aug 6, 2024
13 checks passed
@PaulHuwe PaulHuwe deleted the RAD-172_SkyBackground branch August 6, 2024 13:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add schema for background
6 participants