Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add schema for background #247

Closed
bmorris3 opened this issue May 4, 2023 · 6 comments · Fixed by #432
Closed

Add schema for background #247

bmorris3 opened this issue May 4, 2023 · 6 comments · Fixed by #432

Comments

@bmorris3
Copy link
Contributor

bmorris3 commented May 4, 2023

spacetelescope/romancal#687 implements sky matching for romancal, and updates a (temporary) "background" dictionary in ImageModel.meta. The dict currently has three keys:

  • level (astropy.units.Quantity)
  • subtracted (bool)
  • method (str)

method can have the options defined by the spec:

option('local', 'global', 'match', 'global+match', default='match')

This should be implemented with a schema in rad.

@ddavis-stsci
Copy link
Collaborator

changes merged.

@braingram
Copy link
Collaborator

I'm failing to find a background schema. @ddavis-stsci would you help me locate which schema defines this attribute?

@braingram
Copy link
Collaborator

Per a conversation with @schlafly at the moment background does not have a schema and it's uncertain if it will get one (since it's optional). I'll try to update this issue if I learn more.

@stscijgbot-rstdms
Copy link
Collaborator

This issue is tracked on JIRA as RAD-172.

@PaulHuwe PaulHuwe mentioned this issue Aug 5, 2024
4 tasks
@stscijgbot-rstdms
Copy link
Collaborator

Comment by Paul Huwe on JIRA:

The schema is added in PR-432: #432

 

@stscijgbot-rstdms
Copy link
Collaborator

Comment by Paul Huwe on JIRA:

PR approved and merged.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants