Adjust PSF normalization limits by obs mode #662
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR makes a small adjustment to #552. Normally, the PSFs in the gridded PSF libraries are normalized such that the total signal of the PSF divided by the square of the oversampling factor is just under 1.0. But in the case of NIRISS NRM exposures, the throughput factor of 0.15 associated with the NRM mask is included in the webbpsf PSFs. Therefore the normalization is lower by a factor of 0.15. Similarly, for NIRISS imaging observations that use the CLEARP filter, the throughput factor of 0.84 is included in the webbpsf outputs.
So here, we adjust the normalization check to lower the expected value by factors of 0.15 and 0.84 for these two cases.