Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add normalization check for gridded PSF library #552

Merged
merged 3 commits into from
Apr 15, 2021

Conversation

bhilbert4
Copy link
Collaborator

Resolves #358

This PR adds a simple normalization check to the gridded PSF library read in by Mirage. This will help to identify any improperly normalized libraries. The check expects that the total signal in a PSF divided by the square of the oversampling factor should be roughly 1.0.

I currently have the lower and upper limits for a "good" normalization set at 0.8 and 1.0. @mperrin does that make sense? I'm wondering if having a lower limit makes sense at all.

Also, the libraries for ITM images will never fail this test, as the function that reads in the ITM library file currently manually normalizes the total signal to 1.0.

@bhilbert4 bhilbert4 added PSF Generation Relating to the generation of the simulated PSFs seed image labels Sep 4, 2020
@bhilbert4 bhilbert4 self-assigned this Sep 4, 2020
@bhilbert4 bhilbert4 merged commit 25faa31 into spacetelescope:master Apr 15, 2021
@bhilbert4 bhilbert4 deleted the psf-normalization-check branch April 15, 2021 14:44
@Skyhawk172
Copy link
Contributor

This seems to be causing issues with some NIRISS and FGS PSF grids that were recently generated using the Photutils normalization method (as opposed to strictly normalizing to 1.0). For example, for some NIRISS PSF grids, the total signal in the PSF is a fraction of a percent above 1.0 (e.g. 1.0011332952694405) and the code catches it and halts because it exceeds 1.0. It appears the lower limit affects FGS grids as well. So the limits should be revised and made consistent with the way WebbPSF normalizes its PSF grids.

@mperrin
Copy link
Collaborator

mperrin commented Sep 12, 2021

See now spacetelescope/webbpsf#487

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
PSF Generation Relating to the generation of the simulated PSFs seed image
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add normalization check on gridded PSF library
3 participants