-
Notifications
You must be signed in to change notification settings - Fork 169
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
use PyPI upload workflow from OpenAstronomy #7912
use PyPI upload workflow from OpenAstronomy #7912
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #7912 +/- ##
=======================================
Coverage 75.94% 75.94%
=======================================
Files 460 460
Lines 37629 37629
=======================================
Hits 28577 28577
Misses 9052 9052
*This pull request uses carry forward flags. Click here to find out more. ☔ View full report in Codecov by Sentry. |
715ab4d
to
0ab8e76
Compare
2bb4d2b
to
29282b0
Compare
The following error occurred while building:
|
specifying CPython in the build targets fixed the issue |
40c46b3
to
d0f1669
Compare
45c3b9c
to
7409a3c
Compare
7409a3c
to
df4ba9a
Compare
the source distribution issue in the OpenAstronomy workflow is now resolved (see OpenAstronomy/github-actions-workflows#169); I see no other blockers for merging |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Still no Windows support? Didn't someone fixed it being broken on Windows at some point? Is it broken again?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Also if this is a high traffic repo and building the wheels is resource intensive, should consider only building them when a special label is applied for pull requests. Probably also wise to auto-cancel duplicate builds. See astropy
on how this is done in production.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I left what comments I can. Someone from your team should approve.
I think this fixes #8054 . Thanks!
52ed654
to
7f72bd1
Compare
Is the dev job fixed in a different PR? |
Re: devdeps -- You need pyerfa-dev, see: But even with that, I don't think you can resolve the numpy ABI failure. You have a lot of dependencies that build their own C-extensions. Anything that builds their own need to be built with numpy 2.0 to work with numpy 2.0 (drizzle, spherical-geometry, scikit-image, etc). NumPy claims that stuff built with numpy 2.0 would be backward compatible with 1.x (up to a point). And if you have your own C-extensions, you might also run into compatibility issues in your own build after you resolve the dependencies, so be on the lookout for that. I know that scikit-image is still struggle to provide a dev wheel that is compatible with numpy 2.0, please follow: tl;dr -- You probably can merge this as-is and deal with devdeps later because it is going to be painful. |
Co-authored-by: P. L. Lim <2090236+pllim@users.noreply.github.com>
a35837f
to
d523bb6
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approving - given that dev builds are going to be handled in a different PR.
Resolves SCSB-108
closes #8054
This PR changes the PyPI upload process to use the OpenAstronomy workflow instead of the STScI one. The workflow in this PR is configured to test the build with each pull request push, and then publish upon an official release.
This will facilitate catching build issues early on (ideally within the PR) before the release date. The reusable workflow uses
cibuildwheel
to build wheels for all supported Pythons on Linux, macOS X64, and macOS ARM64 (we don't currently have automated testing for ARM64, but we should soon with the on-prem regtesting effort)We can't use this workflow until we make a PyPI token (with write / upload permission to packages) for the STScI maintainer account. Currently, we use a username and password to PyPI; however, this method will be deprecated at some point in the future in favor of tokens.Checklist for maintainers
added entry inCHANGES.rst
within the relevant release sectionupdated or added relevant testsupdated relevant documentationran regression tests, post a link to the Jenkins job below.How to run regression tests on a PR
Make sure the JIRA ticket is resolved properly