-
Notifications
You must be signed in to change notification settings - Fork 169
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
reorganize tests, make devdeps testing optional, unpin latest Python testing, and prepare for possibility of data caching #7910
reorganize tests, make devdeps testing optional, unpin latest Python testing, and prepare for possibility of data caching #7910
Conversation
64026f1
to
7ff6645
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #7910 +/- ##
=======================================
Coverage 75.42% 75.42%
=======================================
Files 464 464
Lines 37938 37938
=======================================
Hits 28615 28615
Misses 9323 9323
*This pull request uses carry forward flags. Click here to find out more. ☔ View full report in Codecov by Sentry. |
a396478
to
3ae3ca1
Compare
9710a81
to
fa1359b
Compare
d4a7134
to
65a4933
Compare
f94669b
to
07d5c9d
Compare
Why all the CI failures? Looks like something to do with our pinning of the python version <3.12. |
in the regular non-devdeps tests it looks like an issue with
In the
Then for the latest Python ones (
|
Re the numpy build vs runtime: It looks like stdatamodels has the same devdeps issues :-/ |
Ah yes, the "timecoeff" errors are due to an update in the jwst master that is not yet available in the latest stdatamodels release, which is used by the CI tests. It is available, however, in stdatamodels/master. I guess we need an stdatamodels release ASAP. |
07d5c9d
to
d401c5e
Compare
If the regular tests pass here, we can likely merge this and then deal with the Numpy 2.0 devdeps issues in another PR |
So the remaining CI errors all seem to be due to numpy.core.multiarray import errors. Is that what you expect and hence is this ready to merge as-is? |
yes, I think that's expected. This is ready to merge, and then we can fix the devdeps |
Resolves SCSB-79
This PR
run devdeps tests
run scheduled tests
can be used as wellv1
tag to minimize surprises with API changesspacetelescope/crds/.github/workflows/contexts.yml@master
) to improve maintainability of this workflow going forward/tmp/data/
like in other repos'data.yml
workflows (can potentially be packaged into a combined cache)py3
)Checklist for maintainers
added entry inCHANGES.rst
within the relevant release sectionupdated relevant documentationran regression tests, post a link to the Jenkins job below.How to run regression tests on a PR