Fix updating coordinate displaying when blinking via click #1470
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kecnry
added
bug
kecnry
force-pushed
the
blink-click-update
branch
from
5f57cd5
to
a7120ca
Compare
kecnry
requested review from
duytnguyendtn,
rosteen,
javerbukh,
ojustino and
pllim
as code owners
Codecov Report
@@ Coverage Diff @@
## main #1470 +/- ##
==========================================
+ Coverage 85.38% 85.40% +0.02%
==========================================
Files 91 91
Lines 8476 8478 +2
==========================================
+ Hits 7237 7241 +4
+ Misses 1239 1237 -2
Continue to review full report at Codecov.
|
pllim
reviewed
Jul 8, 2022
| @@ -111,9 +111,13 @@ def activate(self): | |||
| def deactivate(self): | |||
| self.viewer.remove_event_callback(self.on_click) | |||
|
|
|||
| def on_click(self, *args): | |||
| def on_click(self, data): | |||
There was a problem hiding this comment.
If you really want to test this, you can write a test that is not unlike what is being done in https://github.com/spacetelescope/jdaviz/blob/main/jdaviz/configs/imviz/tests/test_linking.py 😉
There was a problem hiding this comment.
Since that test already uses the "b" key twice, I just changed one of them to make use of the click (so that we have coverage for both cases).
rosteen
approved these changes
Jul 11, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This pull request fixes the coordinate display (in imviz or cubeviz) to update when blinking via clicking (the "b" hotkey worked already).
This is failing coverage checks - but we never had coverage on the click event and don't have a good way to simulate that afaik.Checklist for package maintainer(s)
This checklist is meant to remind the package maintainer(s) who will review this pull request of some common things to look for. This list is not exhaustive.
triviallabel.CHANGES.rst?