-
Notifications
You must be signed in to change notification settings - Fork 74
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix updating coordinate displaying when blinking via click #1470
Conversation
5f57cd5
to
a7120ca
Compare
Codecov Report
@@ Coverage Diff @@
## main #1470 +/- ##
==========================================
+ Coverage 85.38% 85.40% +0.02%
==========================================
Files 91 91
Lines 8476 8478 +2
==========================================
+ Hits 7237 7241 +4
+ Misses 1239 1237 -2
Continue to review full report at Codecov.
|
@@ -111,9 +111,13 @@ def activate(self): | |||
def deactivate(self): | |||
self.viewer.remove_event_callback(self.on_click) | |||
|
|||
def on_click(self, *args): | |||
def on_click(self, data): |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If you really want to test this, you can write a test that is not unlike what is being done in https://github.com/spacetelescope/jdaviz/blob/main/jdaviz/configs/imviz/tests/test_linking.py 😉
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Since that test already uses the "b" key twice, I just changed one of them to make use of the click (so that we have coverage for both cases).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Works as expected, looks good to me.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Thanks!
Description
This pull request fixes the coordinate display (in imviz or cubeviz) to update when blinking via clicking (the "b" hotkey worked already).
This is failing coverage checks - but we never had coverage on the click event and don't have a good way to simulate that afaik.Checklist for package maintainer(s)
This checklist is meant to remind the package maintainer(s) who will review this pull request of some common things to look for. This list is not exhaustive.
trivial
label.CHANGES.rst
?