-
Notifications
You must be signed in to change notification settings - Fork 74
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Viewer/layer labels #1465
Viewer/layer labels #1465
Conversation
* moved to right for less conflict with axes * viewer/layer select components now use app-wide icons
Codecov Report
@@ Coverage Diff @@
## main #1465 +/- ##
==========================================
+ Coverage 85.38% 85.42% +0.04%
==========================================
Files 91 91
Lines 8476 8544 +68
==========================================
+ Hits 7237 7299 +62
- Misses 1239 1245 +6
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nifty! I tried creating multiple viewers in Imviz via GUI and API, and it didn't break. Also appears nice on dark mode. 😉
* note: this includes subsets which are often on top of data layers. The coordinate display currently shows the top *data* layer as indicated by the icon.
* remove unused traitlet
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great!!
I think this looks good, especially with the colored labels <-> subsets. Can I click on the icon to quick-toggle the visibility of the layer? |
@havok2063 - not as part of this PR, unfortunately... but I'll add that to the list (in the PR description) of potential follow-up efforts. There was also some discussion of using clicking to select which layer is used for mouseover coordinate display, etc, so we will need to think through which is most convenient. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Works well! Thanks Kyle!
Thanks for the reviews/comments/suggestions! |
Description
This pull request implements per-viewer labels showing the viewer reference name as well as the currently loaded/visible layers, with icons that are synced across all viewer/layer dropdown menus in the plugins.
In short, every viewer is given a numbered icon, and every layer is given a lettered icon, which is available to use app-wide (in the UI only) to quickly associate items in dropdowns with the applicable entries in the viewers. These numbers/letters are shown in the upper-right of the viewers to be as out-of-the-way as possible, but hovering over them expands to show the label of the viewer/layer.
Few use-cases (note: since these recordings, the viewer numbered icons have been hidden when there is only a single viewer):
Screen.Recording.2022-07-09.at.2.12.22.PM.mov
Screen.Recording.2022-07-09.at.2.15.17.PM.mov
Screen.Recording.2022-07-09.at.2.16.41.PM.mov
Screen.Recording.2022-07-09.at.2.30.37.PM.mov
included in this PR:
Possible follow-up efforts
Closes #1426
Checklist for package maintainer(s)
This checklist is meant to remind the package maintainer(s) who will review this pull request of some common things to look for. This list is not exhaustive.
trivial
label.CHANGES.rst
?