Enhancement/reusable search bar component #364
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Updated height and border of .searchInputs. Added padding and shortened width of input. Removed the blue x button of input. Added min-height, min-width and padding of .search-icon-div.
search results is clicked or enter is pressed.
Added styling for search-results-container scrollbar.
✅ Deploy Preview for spacelab-main ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
lauraehiller
suggested changes
Jun 2, 2023
Definitely, will do. |
|
Already commented out the podcastArray, btw :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello Spacelab team. This is my solution for: #328.
I've added stylings to the scroll bar in results container. Also removed the blue X that appeared on container on focus:
I've also moved the search icon farther to the left and added search result title as placeholder:
And also the x icon will change to search when user clicks outside of search input:
Input focused:
Input blurred:
Please tell me if all is as expected :)