Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improvement: Reusable Search Bar Component #328

Closed
lauraehiller opened this issue May 5, 2023 · 6 comments
Closed

Improvement: Reusable Search Bar Component #328

lauraehiller opened this issue May 5, 2023 · 6 comments
Labels
Bug Something isn't working Enhancement Improvement on an existing feature

Comments

@lauraehiller
Copy link
Contributor

Improvements to be made:

  • Style scroll bar in results container
  • Remove blue x that appears on right side of container on focus
  • Move search icon farther to the left of the container (so it fits nicely)
  • Add functionality so that when the user clicks on a search term, that term becomes the placeholder for the search bar
  • When the user clicks outside of the search bar, the icon should switch from x to search

If you notice any other bugs/improvements feel free to comment below and add to my list!

@lauraehiller lauraehiller added Bug Something isn't working Enhancement Improvement on an existing feature labels May 5, 2023
@manuel12
Copy link
Contributor

Hello. I would like to work on this issue if that's ok :)

@lauraehiller
Copy link
Contributor Author

@manuel12 That would be great! Request me as a reviewer when you're ready with a PR:)

@manuel12
Copy link
Contributor

@lauraehiller Is there anything more needed here? :)

@ryanfchase
Copy link
Collaborator

Scroll bar container needs to be styled:

image

@ryanfchase
Copy link
Collaborator

Blue x:

image

@fjtria
Copy link
Collaborator

fjtria commented Nov 5, 2024

Addressed by #364.

@fjtria fjtria closed this as completed Nov 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something isn't working Enhancement Improvement on an existing feature
Projects
None yet
Development

No branches or pull requests

4 participants