Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merge main branch into RELEASE branch #463

Closed
fjtria opened this issue Oct 25, 2024 · 2 comments · Fixed by #467
Closed

Merge main branch into RELEASE branch #463

fjtria opened this issue Oct 25, 2024 · 2 comments · Fixed by #467

Comments

@fjtria
Copy link
Collaborator

fjtria commented Oct 25, 2024

The main branch has updates that haven't been pulled to the RELEASE branch. All changes should be pushed to RELEASE before new pull requests are accepted to main.

From now on, all new feature branches should be made off main to avoid building on top of legacy versions.

@fjtria fjtria self-assigned this Nov 1, 2024
@ryanfchase
Copy link
Collaborator

ryanfchase commented Nov 1, 2024

@fjtria
Copy link
Collaborator Author

fjtria commented Nov 1, 2024

Bugs to address

General:

  • Runtime error: NetworkError
    • Added a try-catch to prevent this popup. Error is from failure to fetch RSS blog feed.
      Image

Home:

  • Link to blog page is still down, should we remove it for this deployment?
    • Commented out this part of the homepage.

About:

  • Scrollbar disappears when clicking on meet the team icons, causes the page to shift horizonally as you click in and out of team member profiles
    • Not addressing, About page will be redesigned later.

Discovery:

  • Need padding underneath the filters component

Podcast:

  • Newsletter sign up isn't centered, also needs padding underneath

Blog:

  • Same comments under Home, remove from navbar?
    • Commented out link to this page.

Donate:

  • When using Debit/Credit, the input fields cover the navbar when scrolling down
  • Also the input fields are restricted to a small column, let's use more horizontal space on desktop?
    • Cannot change, restricted by PayPal form.

@fjtria fjtria linked a pull request Nov 5, 2024 that will close this issue
@fjtria fjtria linked a pull request Nov 8, 2024 that will close this issue
5 tasks
@fjtria fjtria closed this as completed Nov 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants