-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Guidebook Tables #28484
Guidebook Tables #28484
Conversation
bless you 🙏 |
Is it possible to set the dimensions of each column? |
A few comments from me:
Otherwise I feel that this serves a useful need and should go in even if it's a little imperfect now. |
it's completely doable to merge them but for the purposes of making tables doing it like this offered the least amount of boilerplate. I guess coloredbox could be renamed TableCell or something to be more clear in that but it's also not strictly bound to that either.
To be quite honest i was having this issue too and couldn't really get decent vertical alignment. It might have to do with how the guidebook constructs text controls. I really was just focused on getting the basics out quickly because ik this is very high priority.
it's really only called "table" because the UI control is called "TableControl." It is indeed more of a grid flow layout but i didn't really want to cause confusion with GridContainer. It's just mirroring the name a la "Box" and "BoxContainer" |
agree with notafet but also id rather this just gets in rn in this state |
…e-wizards#1427) # Description This ports the Guidebook Tables to allow \<Table\> and \<ColorBox\> embeds in the Guidebook. This just adds extra XML tags to use in rich-text. --- # TODO - [x] Cherry-Pick the PR. - [x] Tested to make sure it works. It does actively work. --- # Media <details><summary><h3>Guidebook Screenshot</h3></summary> <p> ![image](https://github.com/user-attachments/assets/289e4c72-dcef-4489-b89e-5a2d6367124f) </p> </details> NOTE: This screenshot was taken in the dev-environment. I just copy-pasted my SOP for Alert Levels to check it, since it uses both the \<Table\> and \<ColorBox\> identifiers. --- # Changelog :cl: - add: Added <Table> and <ColorBox> identifiers. Go wild in SOP! Co-authored-by: Nemanja <98561806+EmoGarbage404@users.noreply.github.com>
About the PR
Adds support for nice looking tables in the guidebook.
the new
<Table>
control allows you to lay stuff out nicely in a table without gridcontainer jank.We also now have
<ColoredBox>
which is basically just Box on a panelcontainer and with better defaults. Good for tables and not much else.Text centering is omegafucked because of guidebook jank but HEY IT WORKS it's good enough for a first pass and doesn't completely suck to write
Technical details
PJB graciously coded TableContainer in the middle of the night to make this shit easy.
TableContainer needs to be moved to engine but this is high priority
Media
made with the following XML
Breaking changes
Changelog
no cl no fun but much thanks to PJB