Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add a '--rna' option #585

Merged
merged 4 commits into from
Jan 3, 2019
Merged

add a '--rna' option #585

merged 4 commits into from
Jan 3, 2019

Conversation

ctb
Copy link
Contributor

@ctb ctb commented Dec 24, 2018

Per #151 this adds --rna as a synonym for --dna.

  • Is it mergeable?
  • make test Did it pass the tests?
  • make coverage Is the new code covered?
  • Did it change the command-line interface? Only additions are allowed
    without a major version increment. Changing file formats also requires a
    major version number increment.
  • Was a spellchecker run on the source code and documentation after
    changes were made?

@ctb
Copy link
Contributor Author

ctb commented Dec 24, 2018

@taylorreiter a review would be appreciated, at your leisure :)

@codecov
Copy link

codecov bot commented Dec 24, 2018

Codecov Report

Merging #585 into master will not change coverage.
The diff coverage is 83.33%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #585   +/-   ##
=======================================
  Coverage   88.64%   88.64%           
=======================================
  Files          25       25           
  Lines        3786     3786           
  Branches       37       37           
=======================================
  Hits         3356     3356           
  Misses        430      430
Impacted Files Coverage Δ
sourmash/sourmash_args.py 95.63% <100%> (ø) ⬆️
sourmash/commands.py 89.33% <66.66%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4ccdd3d...4289c7c. Read the comment docs.

@ctb
Copy link
Contributor Author

ctb commented Dec 24, 2018

Ready for review and merge! (The red flagged coverage differential is not real, it's due to some outdated information.)

@luizirber
Copy link
Member

codecov/patch is not required anymore (I still think it's a good idea to keep codecov/project as a required check)

@ctb
Copy link
Contributor Author

ctb commented Jan 3, 2019

bump!

Copy link
Contributor

@taylorreiter taylorreiter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me!

@luizirber luizirber changed the title [MRG] add a '--rna' option add a '--rna' option Jan 3, 2019
@luizirber luizirber merged commit bddd23f into master Jan 3, 2019
@luizirber luizirber deleted the add/rna branch January 3, 2019 22:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants