MRG: Fix rs214 LCA databases in databases.md
#2690
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The rs214 links are broken for the LCA files, small fix to point to the correct URL folder
Codecov Report
@@ Coverage Diff @@
## latest #2690 +/- ##
==========================================
+ Coverage 85.26% 92.83% +7.56%
==========================================
Files 133 104 -29
Lines 15179 12389 -2790
Branches 2612 2612
==========================================
- Hits 12942 11501 -1441
+ Misses 1936 587 -1349
Partials 301 301
Flags with carried forward coverage won't be shown. Click here to find out more. see 29 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
|
thanks jason! |
13 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The rs214 links are broken for the LCA files, small fix to point to the correct URL folder; the URLs for the rs214 LCA DBs did not get updated in the update of the table for those links.
Currently the DBs in the LCA column of the table are 404ed.
https://sourmash.readthedocs.io/en/latest/databases.html#gtdb-r08-rs214-genomic-representatives-85k
Once the items above are done, and all checks pass, request a review!