Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix lca gather to work on non-DNA databases. #1031

Merged
merged 4 commits into from
Jun 20, 2020
Merged

Fix lca gather to work on non-DNA databases. #1031

merged 4 commits into from
Jun 20, 2020

Conversation

ctb
Copy link
Contributor

@ctb ctb commented Jun 19, 2020

In #1013, we added non-DNA LCA databases but failed to check that lca gather worked on them. This is now fixed. Also adds tests for loading LCA databases with incompatible moltypes, which should fail. And adds a deprecation warning for sourmash lca gather, which will be removed in future versions.

Fixes #1028
Fixes #728


  • Is it mergeable?
  • make test Did it pass the tests?
  • make coverage Is the new code covered?
  • Did it change the command-line interface? Only additions are allowed
    without a major version increment. Changing file formats also requires a
    major version number increment.
  • Was a spellchecker run on the source code and documentation after
    changes were made?

@ctb
Copy link
Contributor Author

ctb commented Jun 19, 2020

Ready for review @bluegenes !

@codecov
Copy link

codecov bot commented Jun 19, 2020

Codecov Report

Merging #1031 into master will increase coverage by 0.02%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1031      +/-   ##
==========================================
+ Coverage   92.31%   92.34%   +0.02%     
==========================================
  Files          72       72              
  Lines        5413     5421       +8     
==========================================
+ Hits         4997     5006       +9     
+ Misses        416      415       -1     
Impacted Files Coverage Δ
sourmash/sbt.py 87.60% <ø> (-0.02%) ⬇️
sourmash/lca/command_gather.py 84.90% <100.00%> (+1.03%) ⬆️
sourmash/lca/lca_db.py 94.70% <100.00%> (+0.08%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8503b10...9972bc0. Read the comment docs.

@ctb
Copy link
Contributor Author

ctb commented Jun 19, 2020

@luizirber let me know if you think we should do deprecations differently.

Copy link
Contributor

@bluegenes bluegenes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tests passing, spot check worked ... lgtm!

@ctb ctb merged commit df2bac0 into master Jun 20, 2020
@ctb ctb deleted the fix_lca_gather branch June 20, 2020 14:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

lca gather not working for other moltypes Deprecate 'sourmash lca gather' in sourmash 3.0
2 participants