incorporate graphql-go patch to fix union/interface inline fragments (2nd try) #14475
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #14475 +/- ##
==========================================
- Coverage 47.05% 47.05% -0.01%
==========================================
Files 1561 1561
Lines 79151 79151
Branches 7075 7031 -44
==========================================
- Hits 37244 37243 -1
- Misses 38185 38186 +1
Partials 3722 3722
|
eseliger
approved these changes
Oct 7, 2020
…(2nd try) I added a test case and fix for the other error in the 2nd commit graph-gophers/graphql-go@653514d of graph-gophers/graphql-go#409. I confirmed that the GraphQL query on the campaigns preview page that previously broke is now working.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I added a test case and fix for the other error in the 2nd commit graph-gophers/graphql-go@653514d of graph-gophers/graphql-go#409. I confirmed that the GraphQL query on the campaigns preview page that previously broke is now working.