fix #241 #409
Merged
fix #241 #409
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Similar to graph-gophers#407, but adds test cases.
sqs
added a commit
to sourcegraph/sourcegraph-public-snapshot
that referenced
this pull request
Sep 25, 2020
sqs
added a commit
to sourcegraph/sourcegraph-public-snapshot
that referenced
this pull request
Sep 28, 2020
sqs
added a commit
to sourcegraph/sourcegraph-public-snapshot
that referenced
this pull request
Sep 29, 2020
keegancsmith
pushed a commit
to sourcegraph/sourcegraph-public-snapshot
that referenced
this pull request
Oct 5, 2020
sqs
added a commit
to sourcegraph/sourcegraph-public-snapshot
that referenced
this pull request
Oct 8, 2020
…(2nd try) I added a test case and fix for the other error in the 2nd commit graph-gophers/graphql-go@653514d of graph-gophers/graphql-go#409. I confirmed that the GraphQL query on the campaigns preview page that previously broke is now working.
sqs
added a commit
to sourcegraph/sourcegraph-public-snapshot
that referenced
this pull request
Oct 10, 2020
…(2nd try) (#14475) I added a test case and fix for the other error in the 2nd commit graph-gophers/graphql-go@653514d of graph-gophers/graphql-go#409. I confirmed that the GraphQL query on the campaigns preview page that previously broke is now working.
|
I'm merging this PR because it has tests. I'll close the other one. Thank you for your effort. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Similar to #407, but adds test cases.
fix #241