Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bench: add option to disable Polly #6557

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Bench: add option to disable Polly #6557

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
fc088f2
Add option to disable Polly for running bench
janhartman Jan 8, 2025
18e8e5b
Use only passthrough var
janhartman Jan 8, 2025
f811e9d
Add disabled to recording modes
janhartman Jan 9, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 4 additions & 3 deletions agent/src/cli/command-bench/command-bench.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -339,7 +339,8 @@ export const benchCommand = new commander.Command('bench')
const recordingMode =
process.env.CODY_RECORDING_MODE === 'passthrough' ? 'passthrough' : 'replay'
const recordingDirectory = path.join(path.dirname(options.evaluationConfig), 'recordings')
const polly = startPollyRecording({
const polly = process.env.DISABLE_POLLY === 'true' ?
null : startPollyRecording({
recordingName: 'cody-bench',
recordingMode: recordingMode,
recordIfMissing: true,
Expand All @@ -352,7 +353,7 @@ export const benchCommand = new commander.Command('bench')
workspacesToRun.map(workspace => evaluateWorkspace(workspace, recordingDirectory))
)
} finally {
await polly.stop()
await polly?.stop()
}
process.exit(0)
})
Expand Down Expand Up @@ -519,4 +520,4 @@ async function indexContextSourcesDir(options: CodyBenchOptions): Promise<void>
}

throw new Error(`Symf index not ready after ${maxWaitTime / 60 / 1000} min, exiting`)
}
}
Loading