-
Notifications
You must be signed in to change notification settings - Fork 328
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bench: add option to disable Polly #6557
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Shouldn't this be covered by CODY_RECORDING_MODE
? Maybe we should check if CODY_RECORDING_MODE === passthrough
and avoid starting the polly recording, instead of introducing a new environment variable.
That option still starts Polly (Polly has a pass-through mode) and causes errors even though it shouldn't. Polly is apparently quite buggy! |
Yep let's do that! I think it's nicer from a user perspective to just have one environment variable, and for us to do the right thing under the hood to make it work. |
Can we just add additional mode like |
@pkukielka Noted! Will adjust. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Polly often randomly fails on requests with no clear error even if passthrough mode is enabled. Since we don't want it enabled for context evals anyway, it's probably better to disable it outright.
Test plan
Running bench with a larger eval set like DS1000 for context now works without errors.