Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

This fixes a bug that was missed in the recent gui_fit PR #109

Merged
merged 1 commit into from
Jun 23, 2021
Merged

This fixes a bug that was missed in the recent gui_fit PR #109

merged 1 commit into from
Jun 23, 2021

Conversation

jzuhone
Copy link
Collaborator

@jzuhone jzuhone commented May 5, 2021

Description

This fixes a bug in xija_gui_fit that was missed in the last PR. The bug surfaces when one toggles the limit lines on and off, and causes a crash.

Testing

  • Passes unit tests on MacOS, linux, Windows (at least one required)
  • Functional testing

taldcroft
taldcroft approved these changes Jun 23, 2021
View reviewed changes
Copy link
Member

@taldcroft taldcroft left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@taldcroft taldcroft merged commit 036057f into sot:master Jun 23, 2021
@javierggt javierggt mentioned this pull request Jul 1, 2021
Closed
This was referenced Aug 31, 2021
Merged
Merged
@javierggt javierggt mentioned this pull request Jan 4, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@taldcroft taldcroft taldcroft approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jzuhone @taldcroft