Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle NoneType self.mons from a pickle #158

Merged
merged 3 commits into from
Jul 19, 2021
Merged

Handle NoneType self.mons from a pickle #158

merged 3 commits into from
Jul 19, 2021

Conversation

jeanconn
Copy link
Contributor

Description

Handle NoneType self.mons from an old proseco pickle

Testing

Fixes #157

@jeanconn
Copy link
Contributor Author

Another option to work around this is just to pass the call_args to (new) proseco and regenerate the catalogs, but that seems not in the spirit of things.

@jeanconn jeanconn requested a review from taldcroft July 19, 2021 13:56
taldcroft
taldcroft previously approved these changes Jul 19, 2021
@taldcroft
Copy link
Member

Agreed we should add a regression test that includes a stored pickle from proseco < 5.0 in order to avoid surprises like this. So why don't you do that as part of this PR.

@taldcroft taldcroft self-requested a review July 19, 2021 14:42
@taldcroft taldcroft dismissed their stale review July 19, 2021 14:42

Decided the regression test is needed.

@jeanconn
Copy link
Contributor Author

Do you want to make an old pickle file or just set a new baseline with a "current" proseco pickle? And then what paces do we need to put the code through for due diligence (run review, roll options?)?

@jeanconn
Copy link
Contributor Author

OK. I went with adding a single-obsid 4.12.1 proseco pkl file and added a test that uses some work-alike code to read the pickle, run review, and check for messages.

@jeanconn jeanconn merged commit 7c0c5d9 into master Jul 19, 2021
@jeanconn jeanconn deleted the old-no-mon-pickle branch July 19, 2021 21:55
This was referenced Aug 31, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

len(self.mons) not compatible with catalogs from proseco < 5.0
2 participants