Improve performance #292
Merged
Improve performance #292
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
taldcroft
commented
Feb 24, 2019
jeanconn
reviewed
Feb 25, 2019
|
I can't tell from the PR text @taldcroft had benched this on linux, but I can report I am seeing the advertised 2x improvement in aggregate on that platform (as in it just took me half as long to run my separate regression test set on kadi). |
|
I never run on linux if I can avoid it. 😄 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This includes #291 and substantially improves performance. Mostly (sadly) this is finding ways around the poor performance of astropy Table, but the good news is that this introduces no algorithmic changes.
For the 1468 catalogs in the standard acq regression test set, there are no diffs. In this set the mean time to generate a catalog was reduced from 1.12 sec to 0.51 sec. At this point the time for ACAReviewTable review is probably significant in the overall performance budget.