-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use np.ndarray instead of ACAImage for dark map #291
Conversation
I was trying to remember if there is anything special in the ACAImage to deal with edge cases, and then just went to try to make a report for a recent catalog with an edge case. Might need a test for this if there isn't one. I haven't checked yet to see if it is failing on the off-the-ccd star, but the same reporting doesn't fail in master.
|
Good catch, looking at this. |
It seems like it (this particular bad_stars_mask error) should be totally unrelated, but my test environments look good and clean. |
Nah, there's got to be something wrong with my test directory, as now I can get the same failure on a new checkout of master (though the "wrong" thing in that case would be that it worked in my test repo on "master"). Or this could be the same as that intermittent failure I was having before (if it ends up just working fine for you). |
Great! I'll see if I can narrow down whatever is going on for me again. |
I think this PR can just get closed as superceded by #292, right? |
The
ACAImage
class is nice and convenient, but sadly even a few lines of pure Python ends up being really slow for array item access. The change in this PR makes the run time about 75-80% of what it is with current master. So for 30 obsids with a current average time of 1.1 sec, that would shave off 6-7 seconds out of 33.0.