Make sure observations with status=0 are not flagged suspect #126
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
make sure observations with OK-status in status-override are OK regardless of what the algorithm says
Description
Currently, observations with
status != 0
in theobs
table of the supplement are excluded from magnitude estimates, but it turns out that observations withstatus == 0
are not included (Issue #121). The expected behavior is that ifstatus == 0
, then they should be markedOK
even if it fails the standard cuts. This PR fixes that.The fix is simple. It mostly follows what is done for excluded observations: there is a list of excluded observations, which are observations in the
obs
table withstatus != 0
, so I added a corresponding list of included observations. The boolean OK flag considers both.Most of the changes are for testing:
Testing
Functional testingFixes #121