remind: fix import streamlining gone haywire #2470
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
"Unexpected AttributeError: 'str' object has no attribute 'utc'" begone.
Fixes a bug I introduced in #2468 by not being careful enough with my imports. Code review or not, I should've caught it. (And I was reminded to finish/open this PR by
mypy --check-untyped-defs
flagging these errors, so that's all the more reason to work toward #2461 in the longer term.)Checklist
make qa
(runsmake quality
andmake test
)Notes
mypy --check-untyped-defs
still reports errors insopel/modules/remind.py
after this patch, but they'll be fixed separately. @SnoopJ and I have been chipping away at that list over the weekend.