You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Some mypy errors that made it into master, which I've been working on this week (patches that became #2462), served as a good demonstration to me that it's probably time to start running type checks as part of CI and make qa.
Assuming I haven't forgotten anything, we'll want a PR that rolls out these changes:
Add mypy target to make qa sequence
Update pull request template checklist to mention mypy in addition to quality and test targets
Add Actions step to run mypy at the correct point in CI (after flake8?)
Care will have to be taken with previously-approved PRs, but any that receive changes after merging the updated CI workflow will have any new errors flagged.
Future idea: Add a Makefile target to run the full GHA suite, using something like nektos/act Not opening its own issue just yet because it's a whole kettle of fish to set up act, which itself requires Docker, which has its own system requirements—then select the correct images to actually behave like a GHA runner, and those images are not small.
The text was updated successfully, but these errors were encountered:
I've started working on the errors left behind now that #2462 is merged, by checking the output of mypy --check-untyped-defs sopel. That's in a mypy-untyped-defs branch, and I think if we're going to start enforcement we might could wait until the rest of the glaring issues are solved. (But if someone else wants to press ahead with CI enforcement sans flag, sure, go ahead.)
Oh, another reason to delay enforcement a little longer is that there's at least one error in sopel/__init__.py that requires a fix to mypy that hasn't been included in a release yet. It was merged a week before mypy 1.3, but wasn't included in that tag; it's been pulled into the upstream release-1.4 branch, though.
mypy is up to v1.5.0 on PyPI now, so the fix we were waiting for should be present going forward. And we already have verification that CI passes with mypy type-checking as part of the process thanks to #2502.
Some
mypy
errors that made it intomaster
, which I've been working on this week (patches that became #2462), served as a good demonstration to me that it's probably time to start running type checks as part of CI andmake qa
.Assuming I haven't forgotten anything, we'll want a PR that rolls out these changes:
mypy
target tomake qa
sequencemypy
in addition toquality
andtest
targetsmypy
at the correct point in CI (afterflake8
?)Care will have to be taken with previously-approved PRs, but any that receive changes after merging the updated CI workflow will have any new errors flagged.
Future idea: Add a Makefile target to run the full GHA suite, using something like nektos/act
Not opening its own issue just yet because it's a whole kettle of fish to set up
act
, which itself requires Docker, which has its own system requirements—then select the correct images to actually behave like a GHA runner, and those images are not small.The text was updated successfully, but these errors were encountered: