config: require owner
only if no owner_account
is set
#2114
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This shifts validation of the
core.owner
setting from the baseStaticSection
class toCoreSection
, by unmarking it as required (removingdefault=NO_DEFAULT
) and checking the values after loading and validating the section has succeeded viasuper()
.Comes with its own tests to validate the new behavior (a habit we should continue trying to keep up).
Checklist
make qa
(runsmake quality
andmake test
)Notes
Will need to undo #2112 once that's merged, and remove any other references to
owner
being required no matter what.Would have loved to raise
ConfigurationError
instead ofValueError
, butconfig
importsconfig.core_section
: