docs: be even more specific that owner is ALWAYS required
#2112
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hm. I really don't like that. I mean, for 7.1.2 I'm fine, it's fixing a problem where we can fix it without breaking change. However, I don't like forcing owner to set a config value that is ignored, it feels a bit weird. I'll see if I can think of something for Sopel 8. |
Exirel
requested changes
Jun 20, 2021
Hard agree. I'm sure you already know this was never intended to be the final word, just a clarification for our stable branch. To that end, you might like what I did with the
|
4 tasks
dgw
force-pushed
the
docs-owner-never-empty
branch
from
7221d1f to
c2a5225
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Noticed that while the docstring for
core_section.CoreSection.ownerspecifies that it's always required, the "Owners & Admins" docs chapter didn't say anything about it, which could lead users to be confused.Checklist
make qa(runsmake qualityandmake test).pyfiles, so I didn't run those.Notes
Don't know yet if we'll need a 7.1.2 release, but I'm sure it'll happen. This is the first PR for it, apparently.