[reboot] make sure the reboot happens even if platform reboot failed #819
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Platform reboot tool could fail if the platform driver didn't load properly. In this case, a reboot is required to recover the device. We need to make sure the reboot tool is robust. Signed-off-by: Ying Xie <ying.xie@microsoft.com>
jleveque
suggested changes
Feb 23, 2020
jleveque
approved these changes
Feb 23, 2020
abdosi
pushed a commit
that referenced
this pull request
Feb 24, 2020
…819) * [reboot] make sure the reboot happens even if platform reboot failed Platform reboot tool could fail if the platform driver didn't load properly. In this case, a reboot is required to recover the device. We need to make sure the reboot tool is robust. Signed-off-by: Ying Xie <ying.xie@microsoft.com> * Rewording * add log message
yxieca
added a commit
that referenced
this pull request
Feb 25, 2020
…819) * [reboot] make sure the reboot happens even if platform reboot failed Platform reboot tool could fail if the platform driver didn't load properly. In this case, a reboot is required to recover the device. We need to make sure the reboot tool is robust. Signed-off-by: Ying Xie <ying.xie@microsoft.com> * Rewording * add log message
yxieca
added
included_in_configlet_201811
Included in 201811 Branch
and removed
included_in_configlet_201811
labels
abdosi
pushed a commit
to abdosi/sonic-utilities
that referenced
this pull request
Aug 4, 2020
…onic-net#819) * [reboot] make sure the reboot happens even if platform reboot failed Platform reboot tool could fail if the platform driver didn't load properly. In this case, a reboot is required to recover the device. We need to make sure the reboot tool is robust. Signed-off-by: Ying Xie <ying.xie@microsoft.com> * Rewording * add log message
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
- What I did
Platform reboot tool could fail if the platform driver didn't load properly. In this case, a reboot is required to recover the device. We need to make sure the reboot tool is robust.
Signed-off-by: Ying Xie ying.xie@microsoft.com