[reboot]: Allow reboot to happen regardless vendor hook errors #3454
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Nazarii Hnydyn <nazariig@nvidia.com>
stepanblyschak
approved these changes
Jul 29, 2024
|
@prgeor Can you please help review this PR? Thanks |
|
@nazariig What is the connection between syncd service startup and your platform's reboot hook? |
|
@prgeor this bug is vendor specific. The flow can be interrupted if |
prgeor
reviewed
Aug 5, 2024
Signed-off-by: Nazarii Hnydyn <nazariig@nvidia.com>
prgeor
approved these changes
Sep 3, 2024
|
@bingwang-ms can you take this to 202405 as a bug fix/improvement |
mssonicbld
pushed a commit
to mssonicbld/sonic-utilities
that referenced
this pull request
Sep 3, 2024
…-net#3454) * [reboot]: Allow reboot to happen regardless vendor hook errors. Signed-off-by: Nazarii Hnydyn <nazariig@nvidia.com> * [reboot]: Handle review comments. Signed-off-by: Nazarii Hnydyn <nazariig@nvidia.com> --------- Signed-off-by: Nazarii Hnydyn <nazariig@nvidia.com>
|
Cherry-pick PR to 202405: #3517 |
mssonicbld
pushed a commit
that referenced
this pull request
Sep 3, 2024
* [reboot]: Allow reboot to happen regardless vendor hook errors. Signed-off-by: Nazarii Hnydyn <nazariig@nvidia.com> * [reboot]: Handle review comments. Signed-off-by: Nazarii Hnydyn <nazariig@nvidia.com> --------- Signed-off-by: Nazarii Hnydyn <nazariig@nvidia.com>
mssonicbld
added
Included in 202405 Branch
and removed
Created PR to 202405 Branch
labels
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Nazarii Hnydyn nazariig@nvidia.com
The fix is aimed to resolve reboot issue when vendor reboot hook is executed during
syncdservice startup.Relevant PRs:
What I did
How I did it
How to verify it
rebootwhensyncdis starting and ASIC reset is in progressPrevious command output (if the output of a command-line utility has changed)
New command output (if the output of a command-line utility has changed)