[action] [PR:3071] route_check.py should not print too many outputs to stdout (#3071) #3092
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…#3071) Otherwise it fills up the pipe and print() will block. When this happens, `route_check.py` will timeout and eventually killed by `monit` after several minutes. #### What I did Add an option in `print_message()` to skip printing. #### How I did it Add an option `write_to_stdout=True`, in `mitigate_installed_not_offloaded_frr_routes()` call `print_message()` with `write_to_stdout=False`. #### How to verify it Manually run route_check.py, verify that the messages were shown in syslog but not in stdout. #### Previous command output (if the output of a command-line utility has changed) #### New command output (if the output of a command-line utility has changed)
|
Original PR: #3071 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Otherwise it fills up the pipe and print() will block. When this happens,
route_check.pywill timeout and eventually killed bymonitafter several minutes.What I did
Add an option in
print_message()to skip printing.How I did it
Add an option
write_to_stdout=True, inmitigate_installed_not_offloaded_frr_routes()callprint_message()withwrite_to_stdout=False.How to verify it
Manually run route_check.py, verify that the messages were shown in syslog but not in stdout.
Previous command output (if the output of a command-line utility has changed)
New command output (if the output of a command-line utility has changed)