route_check.py should not print too many outputs to stdout #3071
Conversation
Otherwise it fills up the pipe and print() will block.
|
@dgsudharsan @prsunny would you help to review and comment? |
|
Can you please check on coverage? Changes lgtm |
|
Changes LGTM. Please add coverage as requested by Prince |
Hi Prince, I wasn't able to add labels to the PR to indicate status and also which branch to cast to... Could you check if I am included in the right group? I am working on the test in the meantime to close the gap. Thanks! |
|
@lolyu for viz |
Otherwise it fills up the pipe and print() will block.
Hi @MaxXiao12 you can add request in the description of PR. The maintainer or release mgr will add tags. |
Updated the PR to request for |
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
…#3071) Otherwise it fills up the pipe and print() will block. When this happens, `route_check.py` will timeout and eventually killed by `monit` after several minutes. #### What I did Add an option in `print_message()` to skip printing. #### How I did it Add an option `write_to_stdout=True`, in `mitigate_installed_not_offloaded_frr_routes()` call `print_message()` with `write_to_stdout=False`. #### How to verify it Manually run route_check.py, verify that the messages were shown in syslog but not in stdout. #### Previous command output (if the output of a command-line utility has changed) #### New command output (if the output of a command-line utility has changed)
|
Cherry-pick PR to 202305: #3092 |
mssonicbld
added
Included in 202305 Branch
and removed
Created PR to 202305 Branch
labels
Otherwise it fills up the pipe and print() will block. When this happens, `route_check.py` will timeout and eventually killed by `monit` after several minutes. #### What I did Add an option in `print_message()` to skip printing. #### How I did it Add an option `write_to_stdout=True`, in `mitigate_installed_not_offloaded_frr_routes()` call `print_message()` with `write_to_stdout=False`. #### How to verify it Manually run route_check.py, verify that the messages were shown in syslog but not in stdout. #### Previous command output (if the output of a command-line utility has changed) #### New command output (if the output of a command-line utility has changed)
Otherwise it fills up the pipe and print() will block. When this happens,
route_check.pywill timeout and eventually killed bymonitafter several minutes.Request to cast the change to
202305branch.What I did
Add an option in
print_message()to skip printing.How I did it
Add an option
write_to_stdout=True, inmitigate_installed_not_offloaded_frr_routes()callprint_message()withwrite_to_stdout=False.How to verify it
Manually run route_check.py, verify that the messages were shown in syslog but not in stdout.
Previous command output (if the output of a command-line utility has changed)
New command output (if the output of a command-line utility has changed)