Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[202211][generate_dump] Revert "Revert generate_dump optimization PR's", add fixes for empty /dump forder and symbolic links #2710

Commits on Mar 9, 2023

  1. [generate_dump] Revert generate_dump optimization PR's sonic-net#2599"…

    …, add fixes for empty /dump forder and symbolic links
    
    - What I did
    3442815 Revert "Revert "Optimize the execution time of the 'show techsupport' script to 5-10%, (sonic-net#2504)""
    c3bd01f Revert "Revert "[generate_dump] Optimize the execution time of 'show techsupport' CLI by parallel function execution (sonic-net#2512)""
    
    Add a fix for the empty /dump folder inside the final tar archive generated by the show techsupport CLI command.
    Add a fix to not follow the symbolic links to avoid duplicate files inside the final tar archive generated by the show techsupport CLI command.
    
    - How I did it
    Modify the scripts/generate_dump script.
    
    - How to verify it
    1. Manual verification
    do the show techsupport CLI command and save output original.tar.gz (with original generate_dump script)
    do the show techsupport CLI command and save output fixes.tar.gz (with the generate_dump script modified by this PR)
    unpack both archives original.tar.gz and fixes.tar.gz
    compare both directories with ncdu & diff --brief --recursive original fixes Linux utilities
    2. Run the community tests
    sonic-mgmt/tests/show_techsupport
    
    Signed-off-by: vadymhlushko-mlnx <vadymh@nvidia.com>
    vadymhlushko-mlnx committed Mar 9, 2023
    Configuration menu
    Copy the full SHA
    7148d23 View commit details
    Browse the repository at this point in the history

Commits on Mar 16, 2023

  1. Configuration menu
    Copy the full SHA
    04a1c38 View commit details
    Browse the repository at this point in the history