[202211][generate_dump] Revert "Revert generate_dump optimization PR's", add fixes for empty /dump forder and symbolic links #2710
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vadymhlushko-mlnx
force-pushed
the
202211-generate-dump-optimization
branch
2 times, most recently
from
16647e1
to
2266400
Compare
…, add fixes for empty /dump forder and symbolic links - What I did 3442815 Revert "Revert "Optimize the execution time of the 'show techsupport' script to 5-10%, (sonic-net#2504)"" c3bd01f Revert "Revert "[generate_dump] Optimize the execution time of 'show techsupport' CLI by parallel function execution (sonic-net#2512)"" Add a fix for the empty /dump folder inside the final tar archive generated by the show techsupport CLI command. Add a fix to not follow the symbolic links to avoid duplicate files inside the final tar archive generated by the show techsupport CLI command. - How I did it Modify the scripts/generate_dump script. - How to verify it 1. Manual verification do the show techsupport CLI command and save output original.tar.gz (with original generate_dump script) do the show techsupport CLI command and save output fixes.tar.gz (with the generate_dump script modified by this PR) unpack both archives original.tar.gz and fixes.tar.gz compare both directories with ncdu & diff --brief --recursive original fixes Linux utilities 2. Run the community tests sonic-mgmt/tests/show_techsupport Signed-off-by: vadymhlushko-mlnx <vadymh@nvidia.com>
vadymhlushko-mlnx
force-pushed
the
202211-generate-dump-optimization
branch
from
2266400
to
7148d23
Compare
|
@StormLiangMS please refer to this backport as an important enhancement to 202211 |
vivekrnv
approved these changes
Mar 14, 2023
dgsudharsan
approved these changes
Mar 14, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What I did
/dumpfolder inside the final tar archive generated by theshow techsupportCLI command.show techsupportCLI command.How I did it
Modify the
scripts/generate_dumpscript.How to verify it
show techsupportCLI command and save outputoriginal.tar.gz(with originalgenerate_dumpscript)show techsupportCLI command and save outputfixes.tar.gz(with thegenerate_dumpscript modified by this PR)original.tar.gzandfixes.tar.gzncdu&diff --brief --recursive original fixesLinux utilitiesPrevious command output (if the output of a command-line utility has changed)
New command output (if the output of a command-line utility has changed)