[ci] No longer pass '--privileged' option to slave container #1446
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lguohan
approved these changes
Feb 19, 2021
|
Test failure is known and unrelated. Merging this PR in spite of it. |
4 tasks
anand-kumar-subramanian
pushed a commit
to anand-kumar-subramanian/sonic-utilities
that referenced
this pull request
Mar 2, 2021
…et#1446) Now that sonic-net#1427 has merged, we should be able to successfully run all unit tests in a non-privileged slave container.
xumia
pushed a commit
to xumia/sonic-utilities
that referenced
this pull request
Jun 28, 2021
…et#1446) Now that sonic-net#1427 has merged, we should be able to successfully run all unit tests in a non-privileged slave container.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What I did
Now that #1427 has merged, we should be able to successfully run all unit tests in a non-privileged slave container.
How I did it
Remove
--privilegedoption from sonic-slave-buster containerHow to verify it
Ensure PR unit tests pass
Previous command output (if the output of a command-line utility has changed)
New command output (if the output of a command-line utility has changed)