Refactor neighbor_advertiser script and use mock for testing #1427
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sumukhatv
changed the title
jleveque
suggested changes
Feb 11, 2021
jleveque
approved these changes
Feb 11, 2021
prsunny
approved these changes
Feb 11, 2021
|
@sumukhatv please create PR for 201911. |
jleveque
added a commit
that referenced
this pull request
Feb 19, 2021
Now that #1427 has merged, we should be able to successfully run all unit tests in a non-privileged slave container.
4 tasks
anand-kumar-subramanian
pushed a commit
to anand-kumar-subramanian/sonic-utilities
that referenced
this pull request
Mar 2, 2021
…et#1427) Refactored code in neighbor_advertiser script and used mock module to unittesting
anand-kumar-subramanian
pushed a commit
to anand-kumar-subramanian/sonic-utilities
that referenced
this pull request
Mar 2, 2021
…et#1446) Now that sonic-net#1427 has merged, we should be able to successfully run all unit tests in a non-privileged slave container.
xumia
pushed a commit
to xumia/sonic-utilities
that referenced
this pull request
Jun 28, 2021
…et#1446) Now that sonic-net#1427 has merged, we should be able to successfully run all unit tests in a non-privileged slave container.
|
This commit could not be cleanly cherry-pick to 202012. Please submit another PR. |
prsunny
pushed a commit
that referenced
this pull request
Sep 15, 2021
stepanblyschak
pushed a commit
to stepanblyschak/sonic-utilities
that referenced
this pull request
Apr 28, 2022
Avoid adding loopback interface (ip link add) when setting nat zone on loopback interface (sonic-net#1434) [acl] Remove Ethertype from L3V6 qualifiers (sonic-net#1433) Sflow fixes during DEL processing (sonic-net#1427) Fix #3971 by skipping create-only SAI attributes when modifying buffer pools or profiles in orchagent (sonic-net#1430) Fix issue: bufferorch only pass the first attribute to sai when setting attribute (sonic-net#1442) Signed-off-by: Abhishek Dosi <abdosi@microsoft.com>
malletvapid23
added a commit
to malletvapid23/Sonic-Utility
that referenced
this pull request
Aug 3, 2023
Now that sonic-net/sonic-utilities#1427 has merged, we should be able to successfully run all unit tests in a non-privileged slave container.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What I did
Refactored code in neighbor_advertiser script and used mock module to unittesting
How I did it
How to verify it
The neighbor_advertiser test will verify it.
Previous command output (if the output of a command-line utility has changed)
New command output (if the output of a command-line utility has changed)